Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bottom bar for navigation, tabs for inbox #578

Closed
wants to merge 13 commits into from
Closed

Add bottom bar for navigation, tabs for inbox #578

wants to merge 13 commits into from

Conversation

chrisirhc
Copy link
Contributor

@chrisirhc chrisirhc commented Mar 22, 2024 •
edited
Loading

I'm currently just fiddling around and looking and what maybe needs to be refactored around to get a similar navigation as the current Zulip app.

At this stage, the PR is a set of minimal changes to make it look/feel closer to a slightly more polished navigation.

So far some findings:

  • A more sophisticated router like go-router might be useful so that we can create deep links that follow the exact routing that the Zulip web client uses. Except with 1 main difference, specifying the server needs to be in the url.
    • Not sure what this would look like, perhaps: https://open.zulip.app/<serverIdentifier>/<path on zulip server>

Screenshot_20240326_215308

Screen_recording_20240326_215102.webm

Note that the animations between the different navigation routes for the bottom navigation bar is slightly incorrect, since it uses a push animation that applies to the entire page including the navigation bar, rather than only animating/transitioning the main body area that's being changed.

Partially addresses #311

@chrisirhc chrisirhc changed the title WIP Add bottom bar for navigation Add bottom bar for navigation, tabs for inbox Mar 26, 2024
@Syrineladeb02
Copy link

Syrineladeb02 commented Apr 10, 2024 •
edited
Loading

Great work on this pull request, Chrisirhc!
I've thoroughly tested the changes you've made, and everything appears to be functioning smoothly.
I particularly appreciate the enhancements made to the navigation bar and the streamlined user experience it provides.

@gnprice gnprice mentioned this pull request Nov 1, 2024
Closed
@gnprice
Copy link
Member

gnprice commented Nov 1, 2024

Thanks @chrisirhc for exploring this and sending the PR!

We've more recently gotten around to thinking through what we want the navigation to look like, and I just wrote down a proper spec for it:

It overlaps with what this PR did, so I've added a link there saying this may be a useful starting point.

A more sophisticated router like go-router might be useful so that we can create deep links that follow the exact routing that the Zulip web client uses. Except with 1 main difference, specifying the server needs to be in the url.

  • Not sure what this would look like, perhaps: https://open.zulip.app/<serverIdentifier>/<path on zulip server>

Yeah, deep links would be a useful feature but are tricky. Previous discussion here:

@gnprice gnprice closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisirhc @Syrineladeb02 @gnprice